Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Since v1.5.0 update, Subfolder color inheritance breaks, with Custom Rainbow Folder Colors snippet #289

Open
Polite-Foliage opened this issue Jun 10, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@Polite-Foliage
Copy link

Polite-Foliage commented Jun 10, 2024

Hi AnubisNekhet,

Thank you so much for your theme. I really enjoy it and it's really making working on obsidian way more enjoyable.
Since today update to v1.5.0, the subfolder color inheritance, doesn't work anymore on files folder nor bookmarks folder when I use the Custom Rainbow Folder Colors snippet.

I. Steps to reproduce the Bug:

So here's the setting I have on AnuPpuccin theme:
in: Style settings/AnuPpuccin/Workspace/Rainbow Folders/Simple Folder Settings, "Enable subfolder color inheritance" is turned on.

It applies well on the bookmarks as you can see below
Screenshot 1, Subfolder color inheritance works on Folders
Screenshot 1b, Subfolder color inheritance works on Bookmarks

But if I enable the Custom Rainbow Folder Colors snippet, suddenly the color inheritance seems to disappear.
Screenshot 2, Custom rainbow colors breaks the Color Inheritance for Folders
Screenshot 2b, Custom rainbow colors breaks the Color Inheritance for Bookmarks

II. Expected behavior:

I guess the subfolder color inheritance should apply to Folders and Bookmarks when using the Custom Rainbow Folder Colors snippet.

III. Additional informations

Also while doing tests, before sending you this message I found that the rainbow style "full" doesn't applies to -Bookmarks_.
When in workspace/rainbow folder, I select the rainbow style "full" and the file recolor toggle is turned "on" in the full folder settings, the color disappear entirely from the Bookmarks.
And it happened with and without the Custom Rainbow Folder Colors snippet.

Screenshot 3, the rainbow style full don't apply to Bookmarks

It doesn't bother me because I use the simple folder settings but I reported it in case it could help someone.

IV. Conclusion

I know that AnuPpuccin is currently on hiatus, and that you don't have a lot of time to dedicate to bug and issues fixing but I still hope that you may have the time in the weeks-months to come, to give us this minor fix of the update.
Thanks again for your amazing theme and good luck for your other projects.

If you need any precision feel free to ask I'll take the time to answer.

@Polite-Foliage Polite-Foliage added the bug Something isn't working label Jun 10, 2024
@pixeljammed
Copy link

I have the same problem as the above user

CleanShot 2024-06-13 at 09 56 43@2x

@ancient-canopies
Copy link

Same. I wish the subfolders would be the same color as the parent folder, the same way it happens when the custom colors are not enabled. But enabling it makes the subfolders follow the order set in the style settings.

I tried chat gpt to help me change the code, but i am a beginner and the code is giant so even trying to input parts, the gpt gets lost and doesn't help.

If someone finds a solution please let us know

@vi-cat
Copy link

vi-cat commented Jun 20, 2024

Same! the rainbow "counter" restarts at the sub folder level even if I have the "Enable subfolder color inheritance" checked.

@cabinha23
Copy link

I´m with the same issue. I already changed to the full folder mode, it's being useful...

@XBY-x
Copy link

XBY-x commented Nov 10, 2024

I'm having this issue too. It only reproduces when the Rainbow style is set to Simple, but I really like Simple mode. Does anyone have a solution for this? Thanks so much!

@DigiRhys
Copy link

Same issue here! I much prefer the look of the Simple settings vs Full so would be great if there was a fix in the works. If I was CSS savvy enough I'd try poking around to fix for myself if I could TTwTT

Apologies for the unnecessary ticket as well that I JUST opened for this – I am NOT git-savvt either and thought I'd searched to make sure I didn't already see an open one, but clearly did not search correctly :') Not sure if I can close/delete that myself (will be trying to, but💀 sorry again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants