You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #124, the NullPointerException thrown from GuavaImmutableCollectionDeserializer::_deserializeContents(...) method is fixed by adding a _tryToAddNull() method to try if null could be added and wrap the NullPointerException if failed. But the call to the method is only added to the first branch of the conditional check. It is found that the second and third branches could also make value null. Thus the _tryToAddNull() method call should be moved outside of the conditional check, just before the builder.add(value) is called to ensure the value must not be null when invoking the builder.add(value) method.
Fixes could be implemented by moving the _tryToAddNull() method call to the end of the conditional check, just before the invocation of the builder.add(value) method.
cowtowncoder
changed the title
GuavaCollectionDeserializer still throw NPE in some circumstancesGuavaCollectionDeserializer still throws NPE in some circumstances
Dec 19, 2023
In #124, the
NullPointerException
thrown fromGuavaImmutableCollectionDeserializer::_deserializeContents(...)
method is fixed by adding a_tryToAddNull()
method to try if null could be added and wrap theNullPointerException
if failed. But the call to the method is only added to the first branch of the conditional check. It is found that the second and third branches could also makevalue
null. Thus the_tryToAddNull()
method call should be moved outside of the conditional check, just before thebuilder.add(value)
is called to ensure the value must not be null when invoking thebuilder.add(value)
method.Fixes could be implemented by moving the
_tryToAddNull()
method call to the end of the conditional check, just before the invocation of thebuilder.add(value)
method.We found this issue by OSS-Fuzz and it is reported in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65117 after the fixes from #124 have been merged.
The text was updated successfully, but these errors were encountered: