Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aldeed:tabular 3.0.0-rc.4 is not Compatible with Meteor 3.0.4 #463

Closed
distalx opened this issue Dec 3, 2024 · 3 comments
Closed

aldeed:tabular 3.0.0-rc.4 is not Compatible with Meteor 3.0.4 #463

distalx opened this issue Dec 3, 2024 · 3 comments

Comments

@distalx
Copy link
Member

distalx commented Dec 3, 2024

Describe the bug
aldeed:tabular version 3.0.0-rc.4 is not functioning correctly with Meteor version 3.0.4. The issue arises because Meteor 3.0.4 utilizes a 3.0.0 version of blaze-html-templates.

To Reproduce
Steps to reproduce the behavior:

  1. Clone the reproduction repository.
  2. Run meteor npm install && meteor in your terminal.
  3. Open localhost:3000 in your web browser.
  4. Observe that the table does not render.

Expected behavior
When following the above steps, the table should render correctly, displaying the default "links" collection data.

Additional context

  • Meteor Version: 3.0.4
  • aldeed:tabular Version: 3.0.0-rc.4

Reproduction Repo: Link to Reproduction Repository

Copy link

github-actions bot commented Dec 3, 2024

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously.
Our goal is to provide long-term lifecycles for packages and keep up
with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time.
Therefore, we can't guarantee your issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit
a pull request, too! We will accompany you in the process with reviews and hints
on how to get development set up.

Please also consider sponsoring the maintainers of the package.
If you don't know who is currently maintaining this package, just leave a comment
and we'll let you know

@distalx distalx changed the title aldeed:tabular 3.0.0-rc.4 Not Compatible with Meteor 3.0.4 aldeed:tabular 3.0.0-rc.4 is not Compatible with Meteor 3.0.4 Dec 3, 2024
@jankapunkt
Copy link
Member

@distalx I checked your repo and it seems you have no datatables npm packages installed. Please see the following comment on why datatables IS NOT a hard-coded dependency anymore:

#459 (comment)

@distalx
Copy link
Member Author

distalx commented Dec 4, 2024

@jankapunkt, thank you for your quick response.

Installing datatables.net and datatables.net-dt for the default style, along with adding the following function call Tabular.init();, resolves my issue.

I have a follow-up question: in the comment, it mentions passing the DataTables instance to the Tabular.init() call like this: Tabular.init({DataTables}). However, if I don't pass the DataTables instance, it still works.

I think the README should be updated to include the following section:
Updating to 3.0

- Make sure to install the DataTables packages from version 3; we are no longer hard-pinning them.

meteor npm install --save datatables.net datatables.net-dt

- Ensure you initialize Tabular on your client-side code as follows:

// Client-side, ideally in `imports/startup/client/index.js`
import Tabular from 'meteor/aldeed:tabular';
import 'datatables.net'
import 'datatables.net-dt/css/dataTables.dataTables.css'
Tabular.init();
// in case of datatables.net >= v2
import Tabular from 'meteor/aldeed:tabular';
import DataTables from 'datatables.net'
import 'datatables.net-dt/css/dataTables.dataTables.css'
Tabular.init({DataTables});

I can raise a PR to update the README.

EDIT: Apologies, I realized that the open PR already covers these changes.

@distalx distalx closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants