Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme dev doesn't support captcha on customer login page #1999

Open
macournoyer opened this issue Oct 8, 2021 · 46 comments
Open

theme dev doesn't support captcha on customer login page #1999

macournoyer opened this issue Oct 8, 2021 · 46 comments
Labels
Area: @shopify/theme @shopify/theme package issues Type: Enhancement New feature or request

Comments

@macournoyer
Copy link
Contributor

Issue summary

When Captcha support is enabled, browsing to http://127.0.0.1:9292/account/login will sometimes trigger the captcha.
Submitting the captcha on http://127.0.0.1:9292/challenge just redirects back to the same page.

See https://community.shopify.com/c/online-store-2-0/unable-to-log-into-customer-account-when-using-shopify-theme/m-p/1343096/highlight/false#M1414

Expected behavior

Solving the captcha should log you in as a customer.

Actual behavior

It just circles back to http://127.0.0.1:9292/challenge.

Tip: include an error message (in a <details></details> tag) if your issue is related to an error

Steps to reproduce the problem

  1. Enable captcha & Customer login in shop settings
  2. shopify theme serve
  3. Browse to http://127.0.0.1:9292/account/login
  4. Submit a bad login
  5. You should be redirected to http://127.0.0.1:9292/challenge
  6. Solving the captcha and clicking "Submit" redirects you back to http://127.0.0.1:9292/challenge

Workaround

Disable captcha for Customer Login.

Specifications

  • App type: theme
  • Operating System: macOS
  • Shell: zsh
  • Ruby version (ruby -v): 2.7.1
@sadsciencee
Copy link

this was an issue with slate too

@pepicrft
Copy link
Contributor

Adding a reference to the discussion on the forum

@pablogiralt
Copy link

use the url with this format
https://mysitename.myshopify.com/?preview_theme_id=129204027619

instead of the localhost url (http://127.0.0.1:9292)

@pinguluk
Copy link

pinguluk commented Feb 1, 2022

It seems also that when I view the order history, the order number link goes again to store url and not localhost
Shopify/shopify-cli#1992 (comment)

@karreiro karreiro removed their assignment Mar 14, 2022
@venerated
Copy link

Is there any other work arounds aside from turning off captcha? Developing a theme on a live store for a client and don't want to mess with their settings.

use the url with this format https://mysitename.myshopify.com/?preview_theme_id=129204027619

instead of the localhost url (http://127.0.0.1:9292)

Doesn't this load the version of the site that is pushed up to Shopify and not what is on the local machine?

@nelsonvassalo
Copy link

Still happening, do we have any reported progress?

@luigimannoni
Copy link

luigimannoni commented Aug 3, 2022

Doesn't this load the version of the site that is pushed up to Shopify and not what is on the local machine?

You can preview the local development theme directly on live if you are running shopify serve just replace the ID with your dev ID or click at the preview link that is generated from the serve script, it will show your local development theme the only thing lacking will be the livereload and you need to refresh the page manually.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.

→ If there's no activity within a week, then a bot will automatically close this.

Thanks for helping to improve Shopify's dev tooling and experience.

@ben-kzn
Copy link

ben-kzn commented Nov 3, 2022

Our team is experiencing this issue right now. We'll try turning off the captcha.

@venerated
Copy link

Our team is experiencing this issue right now. We'll try turning off the captcha.

@ben-kzn luigimannoni's reply above is the work around that worked for me. Only downside is no live reloading, but at least you can edit the pages.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.

→ If there's no activity within a week, then a bot will automatically close this.

Thanks for helping to improve Shopify's dev tooling and experience.

@luigimannoni
Copy link

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.

→ If there's no activity within a week, then a bot will automatically close this.

Thanks for helping to improve Shopify's dev tooling and experience.

Still very much active. Someone should increase the bot threshold

@waxit-dev
Copy link

Disabling the reCAPTCHA worked great! I was able to login and complete testing on the localhost preview no problem. And only ended up with about 5000 bot accounts added to the store by the end of it.. -_-

@sadsciencee
Copy link

@waxit-dev haha, only 5000?

you should be able to preview the theme using the ?preview_theme_id link as mentioned further up this thread

unfortunately no hot reload. if I am doing a lot of detail work on customer account layouts I'll usually use placeholder content in a regular page template until I'm ready to test with live accounts

@karreiro karreiro changed the title theme serve doesn't support captcha on customer login page theme dev doesn't support captcha on customer login page May 29, 2023
@karreiro karreiro transferred this issue from Shopify/shopify-cli May 29, 2023
@karreiro karreiro added Type: Enhancement New feature or request Area: @shopify/theme @shopify/theme package issues labels May 29, 2023
@github-actions
Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@github-actions
Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@vaelu
Copy link

vaelu commented Mar 12, 2024

Still active

@yippptay
Copy link

any idea when this will ever be fixed? it's crazy that it's been over 2 years and it still hasn't been fixed... why is shopify's integration of captcha so broken?

Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@knjshimi
Copy link

still active

Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@danielehrhardt
Copy link

still active

@joeswann
Copy link

joeswann commented Jul 3, 2024

Commenting to add to the collective discussion - a previous solution I had for reverse engineering the recaptcha token to submit forms with JS on published themes now also doesn't work.

So far a more sophisticated reverse engineering approach has been unsuccessful (getting invalid token errors). Is there a current + recommended solution for submitting login etc forms using JS? Shopify Buy uses the Storefront API and doesn't handle sessions.

Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@danielehrhardt
Copy link

still active

@kuglerfeinkost
Copy link

Still active and makes it impossible to develop theme extensions

Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@danielehrhardt
Copy link

still active

@joeswann
Copy link

So far a more sophisticated reverse engineering approach has been unsuccessful

I did get submitting forms via JS working in the end but I'm not 100% on whether using grecaptcha in themes directly violates some policy or other. If someone can check that I'd be happy to share the solution.

This still doesn't work locally though, it gets an invalid captcha token page as the response.

@mgmanzella mgmanzella added Severity: 4 Low Severity and removed Theme Sev-4 Severity: 4 Low Severity labels Dec 5, 2024
@jackkemmish
Copy link

jackkemmish commented Jan 13, 2025

Still happening for us - it seems intermittent however.

We have it turned off and it's still happening in dev mode.

We are getting it for the newsletter signup and customer login in dev mode :(

We are trying to redirect a user to a custom thank you page after newsletter signup, but the captcha not working in dev is making it difficult to test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests