-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Update webhook uris during development (toml config) #4209
Comments
Nice, took me 3 Days until i found this post.. i am so mad. |
Ya this took me a while to really pin down. I put it in as a feature enhancement, but after reading some of the docs and comments on #4222 it sounds like this is actually a bug and it is, in fact, intended to update webhook uris during development. |
lost a few hours due to this behavior too; been a rather confusing initial DX trailing Shopify webhooks for the first time, until you learn the hard way which URLs do update, which don't, and how to work around the issue. echoing OP's current workaround has us run getting relative webhook URLs to auto-update on dev when the cloudflare tunnel domain changes would make initial DX a lot less confusing, and streamline future development. |
Just to clarify for others, the current fix is to run |
@ccharest93 Thanks for clarifying. I've been banging my head for a week on this ! |
cc: @anitameh |
You can also add a I'm using the Shopify app ruby template. I've added a roles = [ "background" ]
[commands]
dev = "bin/shopify app deploy -f" When I run |
Thanks for posting this issue. Also tumbled into this while setting up webhook with relative path. How is everyone dealing with the issue that testing locally needs to run deploy? What if your app is already serving production customers? How do we set up the project so deploy doesn't actually deploy the unstable changes to the customers? |
@bowenng We need to deploy the app every time in development because the URL changes every time (cloudflare tunnel). Since it changes every time, you have to update the urls (for the app proxy, webhooks etc...) on Shopify In production you won't have this problem since the URL is always the same So, you need one This piece of documentation can help you |
==
Thanks, BaggioGiacomo. The documentation is very helpful. I do hope Shopify fixes this integration. It is bad dev experience having to deploy to test local changes. |
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. P.S. You can learn more about why we stale issues here. |
This is still relevant Shopify CLI v3.69.4 |
it is relevant! |
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. P.S. You can learn more about why we stale issues here. |
still relevant 🫡 |
+1 to fix this. Really annoying as is. |
+1 |
@ozzyonfire Are you able to change the label type to bug? I wonder if it would get more attention. It's definitely a bug in my opinion. |
I actually head back from Shopify on the PR that I created. They told me this was a WIP and their team was currently working on it... So hopefully we should see this fixed soon. |
What area(s) will this request affect?
App
What type of change do you want to see?
Substantial change to existing feature
Overview
Update webhook urls when we run
shopify app dev
and haveautomatically_update_urls_on_dev = true
.Motivation
Currently, if we setup our webhooks through the .toml file, we need to deploy in order for the changes to go live to our store.
However, the next time we run
shopify app dev
we will get a new tunnel url for our app. If we haveautomatically_update_urls_on_dev = true
then all of our urls get changed except for the webhook ones. This leads to a somewhat clunky DX of then opening up a new terminal windows to quickly runshopify app deploy
in order for the new urls to get updated.The new way of configuring webhooks through the TOML is so great, I love this new experience, except for updating the urls.
The text was updated successfully, but these errors were encountered: