Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CLI theme dev unable to get into a password protected dev store #4912

Closed
2 tasks done
ethancalvo opened this issue Nov 22, 2024 · 3 comments · Fixed by #4903
Closed
2 tasks done

[Bug]: CLI theme dev unable to get into a password protected dev store #4912

ethancalvo opened this issue Nov 22, 2024 · 3 comments · Fixed by #4903
Labels
Area: @shopify/theme @shopify/theme package issues Type: Bug Something isn't working

Comments

@ethancalvo
Copy link

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Other

Expected behavior

CLI should have opened a browser window displaying the theme under local development.

Actual behavior

After copy/pasting or typing the very easy store password, CLI kept saying "Incorrect store password. Please try again:"

I did remove the store password temporarily. CLI successfully opened a browser window, and I was able to see the store with the theme under local development.

However when the password was re-applied, the CLI went back to saying "Incorrect store password. Please try again:"

Verbose output

With response headers:
 - content-type: text/html; charset=utf-8
 - server-timing: processing;dur=19, db;dur=9, db_async;dur=3.398, asn;desc="30600", edge;desc="MSP", country;desc="US", theme;desc="173973930276", pageType;desc="index", servedBy;desc="97gr", requestID;desc="5d9a0704-a437-4986-a628-7623b42ab2cc-1732311331", cfRequestDuration;dur=64.999819
 - x-request-id: 5d9a0704-a437-4986-a628-7623b42ab2cc-1732311331
    
2024-11-22T21:35:31.460Z: Getting storefront password for shop *********.myshopify.com...
?  Enter your store password:
✔  *********

2024-11-22T21:35:37.690Z: Request to https://*********.myshopify.com/password completed in 140 ms
With response headers:
 - content-type: text/html; charset=utf-8
 - server-timing: processing;dur=14, db;dur=3, db_async;dur=1.714, asn;desc="30600", edge;desc="MSP", country;desc="US", pageType;desc="password", servedBy;desc="mr6s", requestID;desc="80e0df6f-c435-4a5d-9eec-2221768a2ce0-1732311337", cfRequestDuration;dur=106.999874
 - x-request-id: 80e0df6f-c435-4a5d-9eec-2221768a2ce0-1732311337
    
2024-11-22T21:35:37.691Z: Removing storefront password for *********.myshopify.com...
?  Incorrect store password. Please try again:
✔  *********

2024-11-22T21:36:05.811Z: Request to https://*********.myshopify.com/password completed in 124 ms
With response headers:
 - content-type: text/html; charset=utf-8
 - server-timing: processing;dur=6, db;dur=2, db_async;dur=1.73, asn;desc="30600", edge;desc="MSP", country;desc="US", pageType;desc="password", servedBy;desc="dxtj", requestID;desc="541b928f-6217-44a3-a775-19588c826d38-1732311365", cfRequestDuration;dur=87.999821
 - x-request-id: 541b928f-6217-44a3-a775-19588c826d38-1732311365
    
?  Incorrect store password. Please try again:
✔  *********

2024-11-22T21:36:30.603Z: Request to https://*********.myshopify.com/password completed in 135 ms
With response headers:
 - content-type: text/html; charset=utf-8
 - server-timing: processing;dur=7, db;dur=2, db_async;dur=1.842, asn;desc="30600", edge;desc="MSP", country;desc="US", pageType;desc="password", servedBy;desc="n8dx", requestID;desc="1f3c6e03-42d5-4df6-af96-148be1649104-1732311390", cfRequestDuration;dur=98.999977
 - x-request-id: 1f3c6e03-42d5-4df6-af96-148be1649104-1732311390
    
?  Incorrect store password. Please try again:

Reproduction steps

Dockerfile

FROM node:22.11.0-bookworm
RUN apt update && apt upgrade -y
RUN apt install xdg-utils -y
RUN npm install -g @shopify/cli@latest

docker-compose.yml

services:
  shopify:
    build:
      context: .
      dockerfile: Dockerfile
    container_name: Shopify
    volumes:
      - ./venue-theme:/workspaces:cached
    command: sleep infinity

Operating System

Debian Bookworm

Shopify CLI version (check your project's package.json if you're not sure)

3.70.0

Shell

bash

Node version (run node -v if you're not sure)

v22.11.0

What language and version are you using in your application?

Node

@AaronBarcos
Copy link
Contributor

Look at this PR: #4903

Can you check if it is the same problem of the localized url?

@karreiro
Copy link
Contributor

Thank you for working on that fix, @AaronBarcos!

👋 Hey @ethancalvo,

You may try the fix that @AaronBarcos built on this snapshot:

pnpm i -g @shopify/cli@0.0.0-snapshot-20231127081555

Could you please confirm if that fixes the issue for you?

@gonzaloriestra gonzaloriestra added the Area: @shopify/theme @shopify/theme package issues label Nov 28, 2024
@ethancalvo
Copy link
Author

I couldn't install the snapshot. I assume you took it down?

npm install -g @shopify/cli@0.0.0-snapshot-20231127081555
npm error code ETARGET
npm error notarget No matching version found for @shopify/cli@0.0.0-snapshot-20231127081555.
npm error notarget In most cases you or one of your dependencies are requesting
npm error notarget a package version that doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants