Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for fetching unauthorized themes is too generic #5185

Closed
karreiro opened this issue Jan 13, 2025 · 3 comments
Closed

Error message for fetching unauthorized themes is too generic #5185

karreiro opened this issue Jan 13, 2025 · 3 comments
Assignees
Labels
Area: @shopify/theme @shopify/theme package issues good first issue Good for newcomers Severity: 4 Low Severity Type: Enhancement New feature or request

Comments

@karreiro
Copy link
Contributor

karreiro commented Jan 13, 2025

The error message for fetching unauthorized themes is:

Image

However, this is not clear. In a real-use case, the user needed some investigation to realize the theme exists, but it wasn't in the correct store.

Instead, the CLI may print different and more friendly errors depending on the HTTP status to give better clues to users.

@karreiro karreiro added Type: Enhancement New feature or request Area: @shopify/theme @shopify/theme package issues Severity: 4 Low Severity good first issue Good for newcomers labels Jan 13, 2025
@lukecharle
Copy link

I raised this with @karreiro, just wanted to point out that I did receive errors previously that were clear and related to being logged into an account that didn't have access to the store.

I'm on the latest CLI version FYI.

@lukecharle
Copy link

Hey @karreiro appears this is even happening for app commands -> https://community.shopify.dev/t/shopify-app-dev-failed-to-fetch-theme-xxxxxxx/6127

@karreiro karreiro self-assigned this Jan 16, 2025
@karreiro
Copy link
Contributor Author

Thank you for this context, @lukecharle!

This issue was related to #5192 and has been fixed by #5200.

Now, the CLI presents the same message it was presenting before, and that error message no longer appears :)

The release 3.73.2 includes that fix and is already available, so we may close this issue.

Thanks again for bringing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues good first issue Good for newcomers Severity: 4 Low Severity Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants