Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch race condition in callbacks in JobIteration #358

Closed
adrianna-chang-shopify opened this issue Mar 2, 2021 · 1 comment
Closed

Patch race condition in callbacks in JobIteration #358

adrianna-chang-shopify opened this issue Mar 2, 2021 · 1 comment
Labels
bug Something isn't working needs exploration Something we're not sure if we want to build / solve stale

Comments

@adrianna-chang-shopify
Copy link
Contributor

Related to: #335

We patched this in the Maintenance Tasks gem here, but this is reopening JobIteration's private API and is ideally something we should solve upstream if possible.

I attempted to write an upstream patch to do so on this branch, but ran into issues when testing against Core (see CI Build). There are a number of batch iteration jobs that depend on the reenqueue happening from within #iterate_with_enumerator, prior to the shutdown / after perform callbacks happen in order to gracefully retry from the last cursor if an error gets raised while processing a batch. The complexity level for these jobs is quite high, so it will need more investigation.

@adrianna-chang-shopify adrianna-chang-shopify added bug Something isn't working needs exploration Something we're not sure if we want to build / solve labels Mar 2, 2021
Copy link

This issue has been marked as stale because it has not been commented on in two months.
Please reply in order to keep the issue open. Otherwise, it will close in 14 days.
Thank you for contributing!

@github-actions github-actions bot added the stale label Jan 27, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs exploration Something we're not sure if we want to build / solve stale
Projects
None yet
Development

No branches or pull requests

1 participant