Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist Images aren't being rendered on the Recently Played Tracks List #1

Open
5fcgdaeb opened this issue Dec 21, 2019 · 0 comments
Open
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@5fcgdaeb
Copy link

5fcgdaeb commented Dec 21, 2019

Description

The artist images aren't being rendered on the Recently Played Tracks List; only the the name, artists and the date fields are there. This occurs because the Observable for RecentlyPlayedTracks returns before the URLs are set for the tracks.

Expected Behavior

Artist images should be displayed underneath the album name.

Actual Behavior

Artist images are not displayed.

Steps to Reproduce the Problem

  1. Run the app
  2. Click on recently played tracks
  3. Artist images aren't being displayed in cells

Possible solution

Look into the scan operator. You can look at NewReleasesViewModel.swift for reference on how to use scan to append the results of Observables with each other. The correct solution would involve waiting for each call to the Observable return before setting the URLs for the tracks.

Specifications

  • XCode Version: 11
@ThasianX ThasianX added bug Something isn't working help wanted Extra attention is needed labels Dec 22, 2019
@ThasianX ThasianX self-assigned this Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants