From 3ef79eadc32651d262d7fdd03a6cebe88c6f99ab Mon Sep 17 00:00:00 2001
From: Andrew Scribner <ca.scribner+1@gmail.com>
Date: Thu, 30 Nov 2023 19:49:48 -0500
Subject: [PATCH] bump visualization-server rock to ckf-1.8 (kfp 2.0.3)

Changes:
* bump source version from 2.0.0-alpha.7 to 2.0.3
* update version to use '-' instead of '_', as per new rockcraft requirements
* rename base to ubuntu@20.04 as per new rockcraft syntax
* bump python to python3.8 from 3.6 to follow the version used in the upstream image
* removes custom build steps for python part that are no longer necessary (they were needed for a workaround with python 3.6)
---
 visualisation-server/rockcraft.yaml | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/visualisation-server/rockcraft.yaml b/visualisation-server/rockcraft.yaml
index 37e8914..3093c28 100644
--- a/visualisation-server/rockcraft.yaml
+++ b/visualisation-server/rockcraft.yaml
@@ -1,7 +1,7 @@
-# Dockerfile: https://github.com/kubeflow/pipelines/blob/2.0.0-alpha.7/backend/Dockerfile.visualization
+# Dockerfile: https://github.com/kubeflow/pipelines/blob/2.0.3/backend/Dockerfile.visualization
 name: ml-pipeline-visualization-server
-base: ubuntu:20.04
-version: '2.0.0-alpha.7_20.04_1'
+base: ubuntu@20.04
+version: '2.0.3-20.04-1'
 summary: ml-pipeline/visualization-server
 description: |
     ml-pipeline/visualization-server
@@ -13,7 +13,7 @@ run-user: _daemon_
 services:
   vis-server:
     override: replace
-    command: python3.6 /server.py
+    command: python3.8 /server.py
     startup: enabled
 
 package-repositories:
@@ -26,16 +26,17 @@ parts:
     plugin: python
     source: https://github.com/kubeflow/pipelines.git
     source-subdir: backend/src/apiserver/visualization
-    source-tag: 2.0.0-alpha.7
+    source-tag: 2.0.3
     stage-packages:
-    - python3.6-venv
+      # sync this python version to that in the tensorflow 
+      # base image of Dockerfile.visualization.  Also keep this
+      # in sync with PARTS_PYTHON_INTERPRETER below
+    - python3.8-venv
     python-requirements:
     - requirements.txt
-    override-build: |
-      rm "${CRAFT_PART_INSTALL}"/usr/bin/python3.6m
-      ln -s python3.6 "${CRAFT_PART_INSTALL}"/usr/bin/python3
-      craftctl default
-  
+    build-environment: 
+    - PARTS_PYTHON_INTERPRETER: python3.8
+
   gcloud:
     plugin: nil
     stage-packages:
@@ -54,6 +55,6 @@ parts:
   files:
     plugin: nil
     source: https://github.com/kubeflow/pipelines.git
-    source-tag: 2.0.0-alpha.7
+    source-tag: 2.0.3
     override-build: |
       cp -r backend/src/apiserver/visualization/* $CRAFT_PART_INSTALL