Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduledworkflow rock: Substitution of environment variable NAMESPACE is incorect #38

Closed
NohaIhab opened this issue Oct 19, 2023 · 0 comments · Fixed by #39
Closed
Labels
bug Something isn't working

Comments

@NohaIhab
Copy link
Contributor

NohaIhab commented Oct 19, 2023

As seen in issue canonical/kfp-operators#352, specifically the comment: canonical/kfp-operators#352 (comment)
In the scheduledworkflow rock used in kfp-schedwf charm, the substitution of the environment variable NAMESPACE never happens. The command is:

command: /bin/controller --logtostderr=true --namespace=${NAMESPACE}

we can see that the substitution doesn't happen from the logs:

2023-10-13T09:29:08.022Z [controller] E1013 09:29:08.022113      15 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.3/tools/cache/reflector.go:167: Failed to watch *v1alpha1.Workflow: failed to list *v1alpha1.Workflow: workflows.argoproj.io is forbidden: User "system:serviceaccount:kubeflow:kfp-schedwf" cannot list resource "workflows" in API group "argoproj.io" in the namespace "${NAMESPACE}"

the namespace was passed as ${NAMESPACE}, this needs to be fixed in the rock.

and the namespace is hardcoded to kubeflow:

this is an issue because then scheduled workflows in other namespaces will not run.
we should align with the configuration in upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant