Refactor getUserProfile subscriptions

[eleanorreem]

Overview

We want to start breaking up the GET /user/me request and only fetch information on the pages it is needed. This is starting with subscriptions. We created a new endpoint in this ticket to have a bespoke endpoint for getting subscriptions . The frontend migration is in this ticket and blocks this refactor. After the frontend has been migrated over, we can start breaking up the GetUserDto and remove subscriptions from the object.

Action Items

• Remove leftJoins of subscription and subscription_user table from the database query in userService.getUserByFirebaseId.
• This will impact the firebase module and therefore the rest of the site. There may be significant refactors ahead.
• You will need to remove subscription_user and subscription imports from most modules as they will no longer be required.
• Remove all instances of ISubscriptionUser. It should either be an entity or a dto.
• Remove subscriptions property from the GetUserDto.

[leoseg]

Can I try this one? :)

[leoseg]

And I have on question regarding the ticket description, I don't see any left join in the service method of userService.getUserByFirebaseId, as the typeorm query there doesnt specify the relations parameter, are you referring to the controller method with the same name which calls the service method getUserProfile?

[github-actions]

Thank you @leoseg you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request. ✨

---

Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about our impact and sign-up for our volunteer programsto join our mission!. 🌸

[eleanorreem]

Ah yes sorry! There was a recent refactor which means its the getUserProfile function you want to address. However, I just noticed the frontend ticket hasn't been done so this ticket should be blocked 🤔 Would you be interested in doing that work at all? Otherwise you might need to hold out until that piece of work is done by someone else.

[leoseg]

I already started, I could do the refactoring write some unittests and test manually trough swagger, and open a pull request for a first review after that :) The end2end testing with cypress I could do later when its ready. One quick question: which API token do I use for swagger it is the one from firebase? because this one is not working for me

[leoseg]

#710 I opened a first pull request for a first review, I also edited the docker-compose as proposed in #588 as i needed to do it to get docker-compose running on my ubuntu :) I can do further e2e testing when the frontend is ready :) @eleanorreem

[eleanorreem]

@leoseg thanks for opening the PR.

I haven't used Swagger to test API endpoints but I'm imagining you need to have the Firebase Env variables for the backend. Once you have that, I usually use postman and hit the /auth/signin endpoint with a JSON body of {email: string, password: string}. It should return you a token which you can copy into your request headers.

@kyleecodes I don't know if we have any documentation about this but this would be a good thing for us to do!

[leoseg]

Thanks :) Manual testing trough swagger API seems to work, when the frontend is up to date I will do further tests with cypress!