Add requestId and sessionId to logs

[eleanorreem]

Overview

We currently don't log request IDs or session IDs in our logs. These would be hugely helpful with debugging. Every time we call logger.log or logger.error, the output should be decorated with both requestIds and sessionIds. We are currently refactoring/ improving our logs so any suggestions for improving are welcome.

Action Items

• Add sessionID and requestID to logs/errors
• Make a PR and tag @eleanorreem or @annarhughes

Resources/Instructions

• https://yflooi.medium.com/nestjs-request-and-response-logging-with-middleware-b486121e4907
• https://docs.nestjs.com/techniques/session

[chinmaym07]

@eleanorreem can I try my hands on this ?

[github-actions]

Thank you @chinmaym07 you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request shortly ✨

---

Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn here and explore our projects. 🌸

[leoseg]

Hi @chinmaym07 are you still working at this? If not I would like to pick up the issue :) As I see the logging.interceptor already logs the user id of the request as well as the IP, what exactly would the request-ID be? About logging the origin IP of the request, I'm not sure if this could be a privacy issue or what do you think about this?:) Also I there is already a session and session-user but as far as I understand those have different meanings than web sessions, here is a solution for sessions which could the already existing Firebase, maybe this would be a solution!

[github-actions]

Thank you @leoseg you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request. ✨

---

Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about our impact and sign-up for our volunteer programsto join our mission!. 🌸

[eleanorreem]

@leoseg thanks for this! And good catch on the privacy issue.

We are planning to remove IP addresses from our logs as we don't need that information, thank you for the reminder. I am going to prioritise that today.

I think we would want to log the requestId separate from the userId as the userId can make multiple requests at the same ID. A quick google brought me to this suggestion but alternative methods would be valid.

Thanks for your help so far!

[leoseg]

Hi @eleanorreem I created a first pull request here, to hear your thoughts about my implementation idea for logging the request id and session id. I have some problems with my local setup in the moment so until now I only ran the unit tests but I'm on it and let you hear when I did manually test everything.