Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Caching implementation is slow #3983

Open
connorjward opened this issue Jan 17, 2025 · 0 comments
Open

BUG: Caching implementation is slow #3983

connorjward opened this issue Jan 17, 2025 · 0 comments

Comments

@connorjward
Copy link
Contributor

The current implementation of parallel_cache is quite slow.

As an example, running test/tracerEq/test_consistency_2d.py::test_nonconst_tracer[DIRK33]" in Thetis (with the changes from #3982) and a hot cache produces a flamegraph like:

Image

All the parts showing PyOP2 Cache... are where we are accessing the cache.

I think that rewriting this in C/Cython would be quite impactful for problems where we call a lot of very small parloops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant