From cba3d153222389071adc9f9d31a2fb2b90ebcff6 Mon Sep 17 00:00:00 2001 From: Andrew Bassett <43486400+apbassett@users.noreply.github.com> Date: Fri, 12 Apr 2024 00:19:40 -0400 Subject: [PATCH] 19404: Improves reliability of release notes (#117) Fixes an intermittent issue where the release notes that appear in the body of GitHub releases include PR titles from older commits. We have ditched the 3rd party release notes generator we were using in favor of a new one + some proprietary code in our centralized workflow repository. --- .github/workflows/build.yml | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3361a6ef..29b98bab 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -418,6 +418,21 @@ jobs: npm install npm run test + generate-changelog: + if: inputs.build-type == 'release' + secrets: inherit + needs: + - smoke-test-linux-amd64 + - smoke-test-linux-arm64 + - smoke-test-linux-arm64_8a + - smoke-test-macos-amd64 + - smoke-test-macos-amd64-large + - smoke-test-macos-amd64-on-arm64 + - smoke-test-macos-arm64 + - smoke-test-windows-amd64 + - smoke-test-wasm64 + uses: "howsoai/.github/.github/workflows/release-notes.yml@main" + release: if: inputs.build-type == 'release' needs: @@ -430,6 +445,7 @@ jobs: - smoke-test-macos-arm64 - smoke-test-windows-amd64 - smoke-test-wasm64 + - generate-changelog runs-on: ubuntu-latest steps: @@ -443,7 +459,7 @@ jobs: commit: ${{ github.sha }} name: "Amalgam ${{ inputs.version }}" artifactErrorsFailBuild: true - generateReleaseNotes: true + body: ${{ needs.generate-changelog.outputs.changelog }} makeLatest: legacy artifacts: amalgam-*/amalgam-*.tar.gz - artifactContentType: application/gzip + artifactContentType: application/gzip \ No newline at end of file