Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision of hierarchy classes naming #27

Open
mmaltsev opened this issue May 12, 2018 · 5 comments
Open

Revision of hierarchy classes naming #27

mmaltsev opened this issue May 12, 2018 · 5 comments
Assignees

Comments

@mmaltsev
Copy link
Collaborator

mmaltsev commented May 12, 2018

Recently I noticed that some of the hierarchy classes in the STO have different names but seem to describe same things, e.g. rami:LifecycleStatus, rami:LifeCycle_Status and rami:Lifecycle_Status. Therefore, I propose to conduct a careful revision of the classification names and decide on some uniformed naming in each case.

Below, there is a full list of classes which names seemed suspicious for me:

sto:Product
sto:Prodcut

rami:LifecycleStatus
rami:Lifecycle_Status
rami:LifeCycle_Status

rami:Asst
rami:Asset
rami:Assest

rami:safety
rami:Safety

rami:Communication
rami:Communications

rami:ConditionMonitoring
rami:Conditional_Monitoring


rami:AdminShellGeneral
rami:GeneralAdminShell

rami:WorkCenter
rami:Work_Centers
@igrangel
Copy link
Contributor

This is definitely a problem of typing. Can you fix them? Or point the specific lines where you find these errors?

@mmaltsev
Copy link
Collaborator Author

I can defenetly fix them, the only problem is to agree on some uniformed naming. Should we use a CamelCase or an underscore _ to separate words, should the terms be only in singular or only in plural? We can start from figuring out, which one is correct in this case:

rami:WorkCenter
rami:Work_Centers

@igrangel
Copy link
Contributor

igrangel commented May 25, 2018

This is already decided. The ontology is made by following the CamelCase convention. Based on this fact, the other will be errors in typing. When you fix them, please add the links for me to check it.

@igrangel
Copy link
Contributor

The naming for classes, object and data properties should follow the CamelCase notation. @sebbader, can you fix this, e.g., like in this class?

@sebbader
Copy link
Collaborator

Should be fixed with this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants