Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshGenerators aren't really generators #53

Open
jwallwork23 opened this issue Nov 14, 2024 · 0 comments
Open

MeshGenerators aren't really generators #53

jwallwork23 opened this issue Nov 14, 2024 · 0 comments
Labels
clarity Something isn't sufficiently clear

Comments

@jwallwork23
Copy link
Member

"But more generally... connected to point 2, I find the name *Generator a bit misleading since I'd then expect it to generate a different mesh every time we call generate_mesh(). Why not just call it UnstructuredSquareMesh (and similarly for others) since generate_mesh() always generates the same mesh?" - originally posted by @ddundo in review of #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarity Something isn't sufficiently clear
Projects
Development

No branches or pull requests

1 participant