algorithm invoke argument transformation should use MetadataToArgumentsRules

[rupertford]

The lfric_alg_invoke_2_psy_call_trans get_arguments method currently manually iterates over the metadata and should probably use a subclass of MetadataToArgumentsRules. I think there are two subclasses required, one to check the metadata and kernel arguments are consistent (at first just check that the number of arguments match) and the other to pull out the required arguments.

[rupertford]

I'll look at checking that the kernel arguments match the metadata description first.

[rupertford]

Created branch 2188_check_kernel_args

[rupertford]

To check that kernel arguments match I need to count the number of arguments expected by the metadata. I started updating the base class MetadataToArgumentsRules to count these. However, this means I need to have logic understanding the arguments and how many there are for each method which is already going to be captured when generating the arguments when calling a kernel from the PSy layer or when generating stub arguments. Due to this complexity I think it is better to use these to count the number of expected arguments even though it will be less efficient. Therefore I'm going to stop working on this branch until PR #2079 is on master.