Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _symbol property to Routine. #2592

Closed
LonelyCat124 opened this issue May 15, 2024 · 0 comments
Closed

Add _symbol property to Routine. #2592

LonelyCat124 opened this issue May 15, 2024 · 0 comments
Assignees

Comments

@LonelyCat124
Copy link
Collaborator

LonelyCat124 commented May 15, 2024

Rather than the RoutineSymbol belonging to a Routine's SymbolTable, we should instead attach it to the Routine as a property (symbol) similar to how we do for References. This symbol should match (or just be ) the parent containers symbol. This therefore depends on #2575 and probably replaces @JulienRemy 's PR #2570 .

This will change a few things inside PSyclone:

  • All references to own_routine_symbol will need to use this if they expect a RoutineSymbol
  • own_routine_symbol may be no longer needed, and functions will just have a DataSymbol to their own name when required.
  • fparser2.py needs to be update to understand what it should construct for Routines.

Some tests/constructs that involve a Routine without a Container above it will have issues with this implementation - if we have these we will need to work on how to fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant