Skip to content
This repository has been archived by the owner on Dec 18, 2022. It is now read-only.

PDBs not shipped on Windows #595

Open
2 tasks done
Be-ing opened this issue Sep 8, 2021 · 4 comments
Open
2 tasks done

PDBs not shipped on Windows #595

Be-ing opened this issue Sep 8, 2021 · 4 comments
Labels
bug Some kind of fixable problem was encountered

Comments

@Be-ing
Copy link
Contributor

Be-ing commented Sep 8, 2021

Guidelines

  • I have read the guidelines.

Version/Commit hash

any

Describe the bug.

Windows builds do not ship PDBs. It is very doubtful we will ever get backtraces from Windows users without this.

Expected behavior

PDBs for the application are shipped with the builds. PDBs for dependencies are not required.

OS

Windows

Additional context

https://github.com/tenacityteam/tenacity/pull/590#issuecomment-915184512

This issue is not a duplicate

  • I have confirmed this issue isn't a duplicate.
@Be-ing Be-ing added the bug Some kind of fixable problem was encountered label Sep 8, 2021
@n0toose
Copy link
Member

n0toose commented Sep 19, 2021

Compiling this on a fresh machine using Visual Studio 2022 seems to contain the PDF file. As long as it's the Debug build.

2021-09-19_12-57

@AnotherFoxGuy
Copy link
Contributor

@panos The issue is that the PDB isn't included in the windows installer

@n0toose
Copy link
Member

n0toose commented Sep 19, 2021

Yeah, I know, I'm just sort of trying to pinpoint the part that is responsible for including it. Well, for starters, it does exist.

@AnotherFoxGuy
Copy link
Contributor

The reason is that you normally exclude PDB's from the installer, because without the sourcecode installed the PDB's are not useful

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Some kind of fixable problem was encountered
Projects
None yet
Development

No branches or pull requests

3 participants