Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of small improvements for updating to WinUI 2.7 #1011

Open
6 tasks
0x5bfa opened this issue Dec 25, 2021 · 5 comments
Open
6 tasks

A bunch of small improvements for updating to WinUI 2.7 #1011

0x5bfa opened this issue Dec 25, 2021 · 5 comments
Assignees

Comments

@0x5bfa
Copy link

0x5bfa commented Dec 25, 2021

Experience improvement list

  • Use custom icons font (Segoe fluent icons may not be included depending on windows, so either change the set of icons used depending on the version of windows, or add Segoe Fluent Icons to your project as a custom icon for Notepads.)
  • Use Microsoft.UI.Xaml (WinUI2.7 elements)
  • Change the content dialogs from C # source code to XAML + C# code behind.
  • Replace the settings pages with a custom configuration group control.
  • Remove custom control style resource such as navigation views, toggle switches, combo buttons
  • Add support of mica material

Related issue and PR

Additional context

  • I don't think it is necessary to force the corners of the window to be rounded.
  • In windows10 which does not support mica material, it will be replaced by a single theme resource.
  • Notepads owner(@Jasonstein) says:

     I do have a plan but not in a hurry to do so because of the bugs I have seen so far.
     Also the adoption rate of Windows 11 is not even reaching to 2%.
     Having rounded corners in Win 10 is also against its design.
     I expect to update Notepads' visual by EOY.
    

References

Screenshots
image

@0x5bfa 0x5bfa changed the title A bunch of small improvements for windows 11 A bunch of small improvements for updating to WinUI 2.6 Dec 25, 2021
@0x5bfa 0x5bfa changed the title A bunch of small improvements for updating to WinUI 2.6 A bunch of small improvements for updating to WinUI 2.7 Dec 25, 2021
@0x7c13 0x7c13 self-assigned this Apr 9, 2022
@emvaized
Copy link

emvaized commented Mar 20, 2024

After messing around in Visual Studio for a few hours I managed to get the app to look like this:

Screenshot

I think it looks much more modern and fits well to overall Windows 11 esthetics. Would love to see Notepads incorporate a similar design.

@0x5bfa
Copy link
Author

0x5bfa commented Mar 20, 2024

looks great!! i love this.

@Skyyblaze
Copy link

After messing around in Visual Studio for a few hours I managed to get the app to look like this:

Screenshot

I think it looks much more modern and fits well to overall Windows 11 esthetics. Would love to see Notepads incorporate a similar design.

@emvaized That looks amazing, could you make this available as a fork?

@emvaized
Copy link

emvaized commented May 19, 2024

@Skyyblaze
I have it as a fork, but it is based on outdated fork from this pull request and doesn't have some features and improvements from the main branch, added in last few years. I initially wanted to merge all of them manually in my fork, but it turned out to be too tedious...

You also would have to build it yourself if you want to try my fork.

@Skyyblaze
Copy link

@emvaized I see, well I have no coding experience so I sadly don't think I would manage to compile it myself although I still appreciate your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants