-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove AddressAdmin config #1220
Conversation
@vcastellm remember to remove providing the failed setting config flags from yaml/toml file: failed setting zkevm.address-admin flag with value=0xE34aaF64b29273B7D567FCFc40544c014EEe9970 error=no such flag -zkevm.address-admin |
As we're removing a flag that will likely be in use in every node already running cdk-erigon it would be good to add an entry into the |
Let's deprecate it |
Applied feedback @hexoscott @Stefan-Ethernal now we only output a warning log stating that the variable is deprecated. |
Quality Gate passedIssues Measures |
This PR removes the unused config file parameter AdminAddress as it's not needed. No event is being generated with this address so there's no need to read anything.
The admin address is not a contract address but an EOA that can be mutable.
This is aligned in the config in cdk-erigon with zkevm-node.