error add overflow when reconnect

[veerapatyok]

I set max_reconnect_attempts is None(default) to infinity, delay is default and I got error add overflow in file client.rs line 164 (sorry an error are gone).

I see variable reconnect_attempts has type u8 (max is 255) and I think when reconnect is infinity it may get error add to overflow

Is it possible change reconnect_attempts += 1 to reconnect_attempts.wrapping_add(1) or ignore add when set max_reconnect_attempts is None ?

Thank you

[1c3t3a]

Fair assessment! Sounds like a reasonable fix, would you be interested in a PR? Otherwise I could open one. Although I would say your client is in a weird state if it reaches 255 reconnects, taking into account the exponential backoff.

[veerapatyok]

Fair assessment! Sounds like a reasonable fix, would you be interested in a PR? Otherwise I could open one. Although I would say your client is in a weird state if it reaches 255 reconnects, taking into account the exponential backoff.

ok and please grant me because I got error 403 when I push. @1c3t3a

[1c3t3a]

You need to fork the repository and then create a PR :) The process is explained here: https://docs.github.com/de/get-started/quickstart/fork-a-repo

[veerapatyok]

@1c3t3a I created PR #341 and please review

[1c3t3a]

Closed in #341