Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and standardize error handling #15

Open
1dustindavis opened this issue Aug 22, 2018 · 1 comment
Open

Review and standardize error handling #15

1dustindavis opened this issue Aug 22, 2018 · 1 comment

Comments

@1dustindavis
Copy link
Owner

A lot of functions handle errors in different ways. Some handle them within the function, some return to the calling function, others don't do anything with them.

Now that logging is handled consistently with a panic called via gorillalog.Error(). We should implement defer and recover in places where it makes sense (the installer, status, and download pkgs come to mind).

@gyamada619
Copy link

gyamada619 commented Nov 22, 2018

Partially addressed in #38 that @YourCrush and I worked on today. Will continue adding defer and recover logic where I locate mention of gorillalog.Error(), assuming that the program will panic and terminate unless recover is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants