Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method removeOne/removeMany doesn't trigger hooks #11

Open
artzhookov opened this issue Apr 29, 2017 · 1 comment
Open

Method removeOne/removeMany doesn't trigger hooks #11

artzhookov opened this issue Apr 29, 2017 · 1 comment

Comments

@artzhookov
Copy link
Contributor

Native driver has aliases removeOne for deleteOne and removeMany for deleteMany but mongodbext doesn't wrap these methods. So when removeOne/removeMany are called hooks are not triggered.

There two ways to fix this problem:

  1. wrap removeOne/removeMany similar to deleteOne/deleteMany
  2. deprecate this methods

What are you think?

@artzhookov artzhookov changed the title removeOne/removeMany don't trigger hooks Method removeOne/removeMany doesn't trigger hooks Apr 29, 2017
@okv
Copy link
Contributor

okv commented Apr 30, 2017

Seems like these aliases even not documented in mongodb native api.
I think we should treat them as remove method - throw NotSupported error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants