-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scenes autosaving from streetmix result in blank screenshot #1013
Comments
kfarr
changed the title
error upon autosave from streetmix -- cannot set props of null
scenes autosaving from streetmix result in black screen
Jan 10, 2025
kfarr
changed the title
scenes autosaving from streetmix result in black screen
scenes autosaving from streetmix result in blank screenshot
Jan 10, 2025
github-project-automation
bot
moved this to Backlog (Not Ready)
in 3DStreet Dev Tracking
Jan 10, 2025
kfarr
moved this from Backlog (Not Ready)
to To Do - High Prio
in 3DStreet Dev Tracking
Jan 10, 2025
There seems to be a race condition with saving images, im wondering if we can use the posthog way of saving images instead of using aframe. Alternatively, is there a way to wait until the screenshot is created before trying to save? |
Lastly, is there a way to wait for the scene to be loaded prior to the saving function to fire, as opposed to the random 1 second timeout |
#1014 fixes all the issues I saw. |
github-project-automation
bot
moved this from To Do - High Prio
to Done
in 3DStreet Dev Tracking
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a user importing a street from streetmix and the street is automatically saved (per previous PR: specific file is
src/index.js
) then I see an errorThis attempted fix #1009 removed the error from user and properly saves the scene as expected, however now the screenshot is not created and results in a black box being saved as the thumbnail for most scenes
The text was updated successfully, but these errors were encountered: