Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProjectReference records without obsolete projectguid #26

Closed
3F opened this issue May 3, 2020 · 0 comments
Closed

ProjectReference records without obsolete projectguid #26

3F opened this issue May 3, 2020 · 0 comments
Labels
support
Milestone
2.5.2

Comments

@3F
Copy link
Owner

3F commented May 3, 2020 •
edited
Loading

Part of #18. Affects our ProjectReferences implementation.

2.5.1 supports only like this:

<ProjectReference Include="..\WinTabby.Hooks\WinTabby.Hooks.csproj" Project="18816D42-416D-4D2B-83F5-1DF7353184AD" />

But we also need just for this:

<ProjectReference Include="..\WinTabby.Hooks\WinTabby.Hooks.csproj" />

Reported by @NickAcPT here 3F/DllExport#148 (comment)
@3F 3F added the support label May 3, 2020
@3F 3F added this to the 2.5.2 milestone May 3, 2020
@3F 3F mentioned this issue May 3, 2020
Merged
@3F 3F closed this as completed in e07c580 May 4, 2020
3F added a commit that referenced this issue May 5, 2020
@3F
Public release. MvsSln 2.5.2
cd39a8d 
* NEW: Activating ProjectReferences for existing ProjectDependencies (shallow copy) through new flag.
       Issue #25.
        ```
        ProjectDependenciesXml = 0x0800 | ProjectDependencies | Env,
        ```
            Covers ProjectDependencies (SLN) logic using data from project files (XML).
            Helps eliminate miscellaneous units between VS and msbuild world:
            #25 (comment)
            Requires Env with loaded projects (LoadMinimalDefaultData or LoadDefaultData).

            A core feature in .NET DllExport Post-processing:
            3F/DllExport#148

* NEW: `ProjectReference` support without obsolete projectguid. Issue #26.

* NEW: IXProject methods:
       ```
       +IXProject.GetFullPath(string relative)
       ```

* FIXED: Fixed possible empty records in SlnParser.SetProjectItemsConfigs.

* FIXED: Fixed `The given key was not present...` when different case for keys in Item.Metadata.

* FIXED: Fixed protected XProject GetProjectGuid() + GetProjectName() when empty property.

* CHANGED: Compatible signature update for `ForEach<T>` extension method:
           ```
           IEnumerable<T> ForEach<T>(this IEnumerable<T> items, Action<T> act)
           ```

* CHANGED: Updated Microsoft.CSharp 4.7.0 (Only for: netstandard2.0 + netcoreapp2.1)

* CHANGED: Updated Microsoft.Build 16.5.0 (Only for: netcoreapp2.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
support
Projects
None yet
Milestone
2.5.2
Development

No branches or pull requests
1 participant
@3F