Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #315

Open
dov opened this issue Apr 19, 2023 · 1 comment
Open

Fix warnings #315

dov opened this issue Apr 19, 2023 · 1 comment

Comments

@dov
Copy link

dov commented Apr 19, 2023

Compiling under g++ produces lots of warnings.

Examples of warnings:

/space3/pub-repos/lib3mf/Source/Common/MeshImport/NMR_MeshImporter_STL.cpp:196:44: warning: unused variable ‘pFace’ [-Wunused-variable]
  196 |                                 MESHFACE * pFace = pMesh->addFace(pNodes[0], pNodes[1], pNodes[2]);
      |                                            ^~~~~

/space3/pub-repos/lib3mf/Include/Model/Classes/NMR_KeyStoreCEKParams.h:45:43: warning:   ‘NMR::eKeyStoreEncryptAlgorithm NMR::CKeyStoreCEKParams::m_eAlgorithm’ [-Wreorder]
   45 |                 eKeyStoreEncryptAlgorithm m_eAlgorithm;
      |                                           ^~~~~~~~~~~~

/space3/pub-repos/lib3mf/Tests/CPP_Bindings/Source/BeamLattice.cpp:533:24: warning: catching polymorphic type ‘class Lib3MF::ELib3MFException’ by value [-Wcatch-value=]
  533 |                 catch (ELib3MFException) {
      |                        ^~~~~~~~~~~~~~~~
/space3/pub-repos/lib3mf/Tests/CPP_Bindings/Source/SliceStack.cpp:309:35: warning: comparison of integer expressions of different signedness: ‘int’ and ‘Lib3MF_uint64’ {aka ‘long unsigned int’} [-Wsign-compare]
  309 |                 for (int i = 0; i < A->GetSliceRefCount(); i++) {
      |                                 ~~^~~~~~~~~~~~~~~~~~~~~~~

Will you accept pull requests to fix these?

@vijaiaeroastro
Copy link
Collaborator

vijaiaeroastro commented Sep 6, 2024

@dov We would be pleased to welcome any improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants