Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCII STL to 3MF conversion fails #344

Open
vijaiaeroastro opened this issue Feb 7, 2024 · 2 comments
Open

ASCII STL to 3MF conversion fails #344

vijaiaeroastro opened this issue Feb 7, 2024 · 2 comments
Assignees
Milestone

Comments

@vijaiaeroastro
Copy link
Collaborator

I tried reading a simple ASCII stl file with Converter.cpp example
The geometry is just a simple box. The example fails with the following error

------------------------------------------------------------------
3MF Model Converter
lib3mf version = 2.2.0
------------------------------------------------------------------
reading /home/vijai/Documents/Geometries/stl_box_ascii.stl...
Lib3MF Error 5 (Reading from a stream was not possible)

Binary version of same file works. I have attached the ascii stl here.
I am not sure if lib3mf is only designed to read binary STL's. In that case, just let me know and I will close the issue.

stl_box_ascii.zip

@vijaiaeroastro vijaiaeroastro changed the title ASCII STL fails ASCII STL to 3MF conversion fails Feb 7, 2024
@martinweismann
Copy link
Member

It's a missing feature... the current implementation only reads binary STL:

pStream->readIntoBuffer(&aSTLHeader[0], 80, true);

It would be nice to also have ASCII-reading, yes.

@vijaiaeroastro
Copy link
Collaborator Author

Include the ASCII stl reader from #364 into lib3mf.

@vijaiaeroastro vijaiaeroastro self-assigned this Aug 6, 2024
@vijaiaeroastro vijaiaeroastro added this to the 2.4.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants