Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickOSM should check the timeout value against its timeout #459

Open
Gustry opened this issue Mar 27, 2023 · 9 comments
Open

QuickOSM should check the timeout value against its timeout #459

Gustry opened this issue Mar 27, 2023 · 9 comments
Assignees
Labels
bug An identified bug

Comments

@Gustry
Copy link
Member

Gustry commented Mar 27, 2023

From the settings saved in QGIS, QuickOSM should check the value saved and compare it to its own timeout value.

This value can be overriden by the API call per request also.

@Gustry Gustry added the bug An identified bug label Mar 27, 2023
@Gustry Gustry self-assigned this Mar 27, 2023
@BenStonebreaker
Copy link

BenStonebreaker commented Mar 28, 2023

QGIS-Version: 3.22.14-Białowieża
QGIS-Codeversion: 4cde646c
Qt-Version: 5.15.3
Python-Version: 3.9.5
GDAL-Version: 3.6.1
GEOS-Version: 3.11.1-CAPI-1.17.1
PROJ-Version: Rel. 9.1.1, December 1st, 2022
PDAL-Version: 2.4.3 (git-version: f8d673)
Algorithmus beginnt bei: 2023-03-28T09:58:07
Algorithmus Laden Sie OSM Daten aus einer Abfrage in einem Bereich herunter startet…
Eingabeparameter:
{ 'AREA' : 'Bad Rappenau', 'FILE' : 'TEMPORARY_OUTPUT', 'KEY' : 'highway', 'SERVER' : 'https://lz4.overpass-api.de/api/interpreter', 'TIMEOUT' : 25, 'VALUE' : 'public' }

Building the query.
All OSM objects with the key 'highway'='public' in Bad Rappenau are going to be downloaded.
Ergebnisse: {'OUTPUT_OQL_QUERY': '[out:xml] [timeout:25];\n area(3600410526) -> .area_0;\n(\n node"highway"="public";\n way"highway"="public";\n relation"highway"="public";\n);\n(.;>;);\nout body;', 'OUTPUT_URL': 'https://lz4.overpass-api.de/api/interpreter?data=[out:xml] [timeout:25];%0A area(3600410526) -%3E .area_0;%0A(%0A node%22highway%22%3D%22public%22;%0A way%22highway%22%3D%22public%22;%0A relation%22highway%22%3D%22public%22;%0A);%0A(.;%3E;);%0Aout body;&info=QgisQuickOSMPlugin'}
Downloading data and OSM file.
Traceback (most recent call last):
File "C:\Users/r/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\QuickOSM\quick_osm_processing\quickosm_process.py", line 351, in processAlgorithm
return self.process_road(context, url)
File "C:\Users//AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\QuickOSM\quick_osm_processing\quickosm_process.py", line 138, in process_road
osm_file = connexion_overpass_api.run()
File "C:\Users//AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\QuickOSM\core\api\connexion_oapi.py", line 85, in run
raise NetWorkErrorException('Overpass API', ', '.join(self.errors))
QuickOSM.core.exceptions.NetWorkErrorException: Overpass API : Download gescheitert: Das Zeitlimit für die Verbindung wurde überschritten

Execution failed after 42.40 Sekunden

Lade Ergebnis Layer
Algorithmus 'Laden Sie OSM Daten aus einer Abfrage in einem Bereich herunter' beendet

@Gustry
Copy link
Member Author

Gustry commented Mar 28, 2023

@BenStonebreaker and others : it seems you can try to switch to z.overpass-api.de instead of lz4.overpass-api.de, according to this answer on GIS-Se

@Gustry Gustry pinned this issue Mar 28, 2023
@mmd-osm
Copy link

mmd-osm commented Mar 28, 2023

Please use overpass-api.de instead of a single hostname like z.overpass-api.de (which will go out of service soon, and is no longer included in the overpass-api.de DNS record).

@Gustry
Copy link
Member Author

Gustry commented Mar 28, 2023

Thanks @mmd-osm I was thinking the same this afternoon about a few tickets coming on GitHub. What is the best way to see this kind of updates ? I was looking on https://wiki.openstreetmap.org/wiki/Overpass_API/status this afternoon to see some news.

I was proposing z.overpass-api.de because it's second on in the pre-configured list : https://github.com/3liz/QuickOSM/blob/master/QuickOSM/definitions/overpass.py#L26

I will remove these 2 and use a single one tomorrow.

@Gustry
Copy link
Member Author

Gustry commented Mar 28, 2023

A previous PR changing the list of server : #173

@Gustry
Copy link
Member Author

Gustry commented Mar 29, 2023

Done 9b8b58d

Please upgrade to 2.2.1

@mmd-osm
Copy link

mmd-osm commented Apr 12, 2023

I added some comments here https://wiki.openstreetmap.org/wiki/Overpass_API/status to improve the situation a bit.

@Gustry
Copy link
Member Author

Gustry commented Apr 13, 2023

Thanks @mmd-osm for raising the issue on the Overpass API side. I saw that the DNS will be updated soon to forward request to new servers.
From a QGIS side, we can only encourage people to upgrade their plugins.

@mmd-osm
Copy link

mmd-osm commented Apr 14, 2023

Meanwhile the old hostnames point to the two new servers, including proper set up of server certificates. At this point I would expect that users of older QuickOSM releases could continue using the tool as before. Avoiding hard coded server names is still recommend to avoid similar issues in the future.

@3liz 3liz deleted a comment from ShahinBa Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An identified bug
Projects
None yet
Development

No branches or pull requests

3 participants