-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow backend host and Port configurable #31
Comments
This appears to already be supported by the
The last two variants allow a custom host to be used (rather than the default which is ServiceApiDriver driver = new ServiceApiDriver(KEY, "myserver.foo.com:8080"); Or if you were using https on a custom port you could do this: ServiceApiDriver driver = new ServiceApiDriver(KEY, "myserver.foo.com:8443", true); This isn't great, admittedly. The code just creates a string and then uses that to create a URL, which isn't the best way to connect to a server, but it DOES work. I could update the documentation (readme) if that's helpful. Or if major improvements to this code are desired, I could spend some time bettering it. :) |
@EricWittmann Thank you very much! yes, a major improvement would be needed. It would be very helpful if you had some time for bettering it :-) |
OK I'll leave the documentation to you, then. :) I'll hold off any any significant changes for later, and only focus on minimal changes required for this upcoming on-prem release. We should save any breaking changes I might make for a new major version of the plugin. So I consider this Issue as "done" from a coding perspective. But perhaps it should remain open and assigned to @avilatusell until the docs are updated? |
OK, thanks! @EricWittmann |
The default_host = "su1.3scale.net".
To work with on-prem version, the host and the port would need to be configurable.
The text was updated successfully, but these errors were encountered: