Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileDownloadLinkComponent does not consider current value of configuration key request.item.type #48

Open
saschaszott opened this issue Aug 14, 2023 · 0 comments
Labels

Comments

@saschaszott
Copy link

DS and DS CRIS allow to disable the request-a-copy feature by setting request.item.type to an empty value (see https://github.com/4Science/DSpace/blob/0c4ee1a65dca7b0bc3382c1a6a642ac94a0a4fba/dspace/config/dspace.cfg#L1674 for details).

Currently, this configuration setting is not propagated from the backend to the frontend.

The current implementation in FileDownloadButtonComponent does not consider the status of request.item.type. The template (src/app/shared/file-download-button/file-download-button.component.html)renders a Request a copy button if the user cannot access the bitstream at hand.

image

To fix this bug a conditional check is required in

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant