forked from DSpace/dspace-angular
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch site object in cms has siteobject with defaultProjection in response #56
Labels
Comments
floriangantner
added a commit
to uniba-ub/dspace-angular
that referenced
this issue
Nov 9, 2023
This was referenced Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The site object is usually returned in allLanguages Projection.
dspace-angular/src/app/core/data/site-data.service.ts
Line 51 in 30543a4
Using the cms metadata component to edit the site object returns some patch(ed) Object with the default projection.
dspace-angular/src/app/admin/edit-cms-metadata/edit-cms-metadata.component.ts
Line 78 in 30543a4
To Reproduce
Steps to reproduce the behavior:
define and configure some cms in two languages (e.g. en,de)
Edit both of the entries and save.
![Screenshot 2023-11-07 at 11-36-17 FIS Universität Bamberg Edit CMS Metadata](https://private-user-images.githubusercontent.com/33422716/281009080-1925390c-796c-459b-a7f0-07e48616ceb6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NjQ4MDAsIm5iZiI6MTcyNTk2NDUwMCwicGF0aCI6Ii8zMzQyMjcxNi8yODEwMDkwODAtMTkyNTM5MGMtNzk2Yy00NTliLWE3ZjAtMDdlNDg2MTZjZWI2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDEwMzUwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUwNDNhZjQwMjI1YTdkMjY3MDIyMTczZTFkYjAzMTgwYzYzMzQ4ZGVjYTFhZjUzNDk2YmY3ZjgwZTFlZmFmNjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.giQbecH3Msw6IsnvM7SvoPyhmLyoTWMwPh-hV8N8Hlg)
You are returned to the dropdown of selected cms metadata.
![Screenshot 2023-11-07 at 11-36-27 FIS Universität Bamberg Edit CMS Metadata](https://private-user-images.githubusercontent.com/33422716/281009176-a30fee3e-10e8-47a1-ae47-8d76116f500c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NjQ4MDAsIm5iZiI6MTcyNTk2NDUwMCwicGF0aCI6Ii8zMzQyMjcxNi8yODEwMDkxNzYtYTMwZmVlM2UtMTBlOC00N2ExLWFlNDctOGQ3NjExNmY1MDBjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDEwMzUwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRjYjlkMmQ1YzI1YmVkOGJjNzVhMzQ1YTk4ZTIzMjYzOGY5MWFmYjYzNmY5MDkwYmI5ZjcxYWM2NDVlMmEyNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.3cjwbmmR8yiou3xUzPRWIjBkntuMsOg-lDOORiO1Iv4)
visit entry again
the entry in the none-main language (=de) should be empty
![Screenshot 2023-11-07 at 11-36-33 FIS Universität Bamberg Edit CMS Metadata](https://private-user-images.githubusercontent.com/33422716/281009204-1cf80df4-f175-4a7a-b602-dd0e76ad2957.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NjQ4MDAsIm5iZiI6MTcyNTk2NDUwMCwicGF0aCI6Ii8zMzQyMjcxNi8yODEwMDkyMDQtMWNmODBkZjQtZjE3NS00YTdhLWI2MDItZGQwZTc2YWQyOTU3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDEwMzUwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY4ODY0NDA5N2I1MThkNmUwMjVlOGM3ODdmOTkwNTkyZTU0ZjJhYTQzM2IyY2MzNzMwYzVkMDFmOTMwMjc4ZDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Tg0JoBujywCt8Ab3vapq96Xj-eJbI824-CPX-dRpqyI)
Administers which might click the save button loose the previously saved data.
Expected behavior
We expect the site object to be returned correctly with all languages or to be reloaded after the change
Related work
Link to any related tickets or PRs here.
The text was updated successfully, but these errors were encountered: