Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #7

Open
9 of 19 tasks
8eecf0d2 opened this issue Oct 15, 2018 · 1 comment
Open
9 of 19 tasks

Add tests #7

8eecf0d2 opened this issue Oct 15, 2018 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@8eecf0d2
Copy link
Owner

8eecf0d2 commented Oct 15, 2018

Since the different Netlify Services aren't completely defined, testing will be based on current assumptions about how things should work. In addition to writing tests, adding more error handlers should be considered (eg, invalid webpack config).

Unit Tests

Config

  • parseWebpackConfig()
  • parseNetlifyConfig()

Webpack

  • Webpack.initialize()
  • Webpack.watch()
  • Webpack.build()

Server

  • Server.initialize()
  • Server.listen()
  • Server.close()
  • Server.routeRedirects()
  • Server.routeHeaders()
  • Server.routeLambdas()
  • Server.lambdaRequest()
  • Server.lambdaContext()

Integration (sorta functional)

Redirects

  • Standard Redirect
  • Standard Rewrite
  • Proxy Rewrite
  • Placeholder (Path Params)
  • Placeholder (Query Params)
  • Force
@8eecf0d2 8eecf0d2 added the enhancement New feature or request label Oct 15, 2018
8eecf0d2 added a commit that referenced this issue Oct 16, 2018
@8eecf0d2
Copy link
Owner Author

It'd be great to also add integration tests or maybe skip those and add functional ones (could have caught things like #9)

@8eecf0d2 8eecf0d2 added the help wanted Extra attention is needed label Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant