Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using keyring on Linux leaves dbus-daemons running, perhaps because godbus connection is not closed #103

Open
afunix opened this issue Jan 22, 2022 · 2 comments

Comments

@afunix
Copy link

afunix commented Jan 22, 2022

My app does not use "secret-service" backend on Linux, however each execution leaves dbus-daemon running, which eventually leads to OutOfMemory.
godbus.Conn has both Open() and Close(), however keyring does not have a Close() method, so there is no way to request Close() in godbus.Conn. I'm not 100% sure Close() will help, but it seems godbus does a lot of clean up in this method.

@Jeffail
Copy link

Jeffail commented Apr 12, 2023

Is there any intention to fix this? I can avoid using 99designs/keyring myself, but every time a dependency makes the unfortunate decision to import this package it also becomes harmful and I have to avoid it.

@Jeffail
Copy link

Jeffail commented Apr 12, 2023

For anyone stuck on this I've made a temporary fork: https://github.com/Jeffail/keyring, here's what the switch looks like (you add a replace directive and it nukes dbus functionality): redpanda-data/connect@7453f87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants