-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make this app open-source. #28
Comments
The plan is to release code on Jan 1 under a fairly restrictive license. |
@AChep Thank you so much for keeping up on your promise. Thank you so much. I love the Material You Design. Keep Up the good work and i am excited for the first release on github(or not i can also build it myself). |
This is not technically "open source", as the current license basically doesn't allow derivatives. That may change in the future, but for now it will stay as it is. |
Yes i know but the Source Code is uploaded. I can now safely use the app. Not that i dont trust you, i just try to avoid closed source stuff and thats why i did not use it until now. |
Thank you for uploading the source. |
In short, I want Keyguard to be my part time job and not just a hobby. For that it needs to be monetized. I'm afraid that if I use a proper open source license, there will be a fork that just mirrors all the code changed with the paywall cut off. Donations are enough for the supply of cookies, but not close to be even a part time job. |
@AChep is there any plans for a iOS version? I was interested in in forking and developing one, but if your intent is to monetize and license is restrictive I don't want to overstep. Love what you're doing with this project, keep it up! |
I'm not an iOS developer, but I will give it a try after Compose for iOS goes stable. |
Sweet!! Neither am I, but I love what you're doing here and it sounds like a fun way to learn 😁 |
@AChep have you considered an "eventually open-source" license like BSL or, even better, its improved and simplified version, FSL? FSL works like this:
That would prevent someone just creating a "paywall-free" version, because they'll only be allowed to do that with an old version of your app |
I did and most likely Keyguard will eventually end up as FSL. |
@AChep that's great to hear, thanks! |
With Bitwarden moving to hostile licence. Is they any update on Keyguard licensing? What about using AGPL to protect the codebase? or the ACSL if you want to block large company? |
I would recommend using a custom/modified license based on the FSL, but after 2 years license the code under the GNU AGPL instead of a "permissive" MIT or Apache license, in oder to protect the code from being used in proprietary products. |
Since the Bitwarden Official Clients are only Source Available, this (with Vaultwarden, which is AGPL) would be (imo) the defacto open source way to use Bitwarden. If both Projects are open source, it might also be interesting to advertise Vaultwarden + Keyguard as an entirely open source solution to Password Managing (that additionally is superb). FSL modified to release under AGPL would be absolutely amazing for this purpose. |
@Surferlul The Bitwarden Android client is GPLv3 licensed |
@flexagoon The Desktop, CLI, and web apps aren't. Large parts of the Desktop apps are GPL, but they depend on the internal Bitwarden SDK which isn't. See https://github.com/bitwarden/clients/blob/e91741b1466428303d5cd3429525c83b39ed5841/package.json#L161
Also, the Android App can't be put onto F-Droid, because the SDK is not FOSS is general as of bitwarden/sdk#898. There are no Plans of changing this. |
@Surferlul, I'm the author of that cited issue. I suggest you read my last comment in its thread - bitwarden/sdk#898 (comment):
Summarily, the proprietary component of the SDK was separated from the rest of the SDK, and now applies solely to the secrets manager. This means that although the SDK remains a dependency of the clients, it is FOSS. |
@RokeJulianLockhart Well I'm glad to have been Proved wrong. The change means that the Desktop clients are also FOSS now, right? |
@Surferlul, to my knowledge. See bitwarden/clients#11611 (comment) (formatted and spell-checked):
|
This app looks and works amazing, there are reasons why it would be nice to make this app open-source:
Adds more trust in the app, this is a password manager after all and I think a level of trust would be nice <3
Allowing users to make pull requests for adding more features and faster bug fixing.
(There are probably other reasons but these are the only two I can think of in the top of my head)
This is just a.. proposal? Recommendation? Whatever, you don't have to make it open-source, but I hope you can take this into consideration! Anyways, great app :)
The text was updated successfully, but these errors were encountered: