Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Autofill on Samsung #45

Open
yurividal opened this issue Dec 30, 2023 · 8 comments
Open

Inline Autofill on Samsung #45

yurividal opened this issue Dec 30, 2023 · 8 comments

Comments

@yurividal
Copy link

Hi. Thank you for open-sourcing this amazing app. It's beautiful and well designed, and fast. Amazing work.

Have you managed to work arround Samsung's whitelist of PW managers? Could you perhaps distribute a version that uses some whiltelisted package name? (Maybe distribute it on reddit, to avoid any issues here?).

@AChep
Copy link
Owner

AChep commented Dec 30, 2023

You might want to poke them here https://forum.developer.samsung.com/t/add-keyguard-for-bitwarden-to-a-list-of-autofill-apps/25698

Yeah, I might create a Samsung flavored build.

@yurividal
Copy link
Author

I managed to do it myself with this:

I used this tool here:
https://github.com/dvaoru/ApkRenamer

I renamed the package to com.agilebits.onepassword
(1password) And now autofill works with keypass.

If you want, I can write an "unofficial guide" on keygard reddit page for other people to be able to do it too.

@ido1901
Copy link

ido1901 commented Jan 20, 2024

It seems to work for me without changing the package name?
Latest Samsung Internet (23 something), latest Keyguard, and Swiftkey Keyboard (although I've checked and it shows with Samsung Keyboard as well).
Only issue in that in custom tabs (and some other rare occasions) it will send the Samsung Internet package name instead of the current website, thus suggesting only my Samsung Account credentials. But that happens for me also with Bitwarden and with changing the package name to "com.agilebits.onepassword" so I think it's more of a Samsung Internet problem and not Keyguard..

@yurividal
Copy link
Author

It seems to work for me without changing the package name? Latest Samsung Internet (23 something), latest Keyguard, and Swiftkey Keyboard (although I've checked and it shows with Samsung Keyboard as well). Only issue in that in custom tabs (and some other rare occasions) it will send the Samsung Internet package name instead of the current website, thus suggesting only my Samsung Account credentials. But that happens for me also with Bitwarden and with changing the package name to "com.agilebits.onepassword" so I think it's more of a Samsung Internet problem and not Keyguard..

Are you sure? Do you get the INLINE autofill? (The one that shows the login button on the keyboard)

@ido1901
Copy link

ido1901 commented Jan 21, 2024

Yeah. Can't see the Samsung Internet UI on this screenshot, but I promise it is 😅 Keygaurd is latest release from Github.
Screenshot_20240121_082920_Samsung Internet

@SgtChrischi
Copy link

I managed to do it myself with this:

I used this tool here: https://github.com/dvaoru/ApkRenamer

I renamed the package to com.agilebits.onepassword (1password) And now autofill works with keypass.

If you want, I can write an "unofficial guide" on keygard reddit page for other people to be able to do it too.

Would be nice if you could do that, since its still not working.

@yurividal
Copy link
Author

@AChep
Seems like the Bitwarden team managed to get the beta app package name whitelisted by Samsung to be used in their browser. Maybe it's worth trying to figure out how they did it in order to get keyguard finally added two Samsungs in line autofill white list.

@yurividal
Copy link
Author

@AChep any progress on this? I'd assume no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants