Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add Advanced Blocking Card #116

Open
MicroObsidianBlock opened this issue Sep 27, 2023 · 6 comments
Open

[Request] Add Advanced Blocking Card #116

MicroObsidianBlock opened this issue Sep 27, 2023 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@MicroObsidianBlock
Copy link

Can you port the advanced blocking card from GTNH for interfaces. I am posting here because I think to be able to block the fluids, it's only possible to ask here rather than in PAE2's.

[https://github.com/GTNewHorizons/Applied-Energistics-2-Unofficial/pull/308]

I will cite this in PAE2's issues.

@YiRanMushroom
Copy link

You are right, the assembly line automation is really a pain at 1.12.2, espetially when it now need to be ordered

@GlodBlock GlodBlock added the enhancement New feature or request label Oct 1, 2023
@YiRanMushroom
Copy link

I checked the source code of the card and found out that the advanced blocking card is actually hard to code. Instead, I think try to do a lock feature of the interface could be easier, like that in 1.19.2, lock craft until primary output is inserted. The thing for advanced blocking card is hard because the storage bus would recognize the network that it is facing, rather than a normal inventory. So I think add the lock feature would work as you want. Also it's hard for the mod to do it (at least I don't know how to do without directly editing PAE2). So maybe you could go to there to show the problem.

@YiRanMushroom
Copy link

Also to detect the primary output is hard, but I don't think we need to do that, we only need to detect if there is items being imported to the interface and that is much easier.

@MicroObsidianBlock
Copy link
Author

Yes, that is an option, and I think is better than the advanced blocking card. I don't know if it is hard to check the primary output, but to check if there is item going in should not be that hard

@GlodBlock GlodBlock added this to the 2.5.0 milestone Nov 6, 2023
@GlodBlock
Copy link
Collaborator

it seems that ae2 itself already supports this feature, interface blocking mode will check the me network inventory instead of interface itself.

@CactusCool
Copy link

CactusCool commented Dec 16, 2023

it seems that ae2 itself already supports this feature, interface blocking mode will check the me network inventory instead of interface itself.

yea but sadly it only works in regular interfaces and not with duals. Even if the same blocking logic the regular interfaces use (only items) was copied to the dual interface it would still be fine as the discretizer should expose fluid as items in the network allowing it to be blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants