-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS / TS Client library #43
Comments
Hey @jakubno, |
Wow @alchaplinsky that looks awesome! I'd love to make a new repo for it and transition it over, although I do have some concerns. Mainly in that it doesn't look like it uses the Open API generator for the spec (which means you wrote it all manually right?) I did the same thing with the TS SDK early on 😆 If you want to keep improving it and base it on the openapi.yml spec, I'd be happy to bring it into the fold 👍 |
@jzanecook Yeah, it's not generated, it's something that I put together while playing with SDK. I'll look closer into openapi.yml spec, definitely better to have based on certain standards. I'd love to keep improving and evolving it and hopefully contribute to other repos as well! |
@alchaplinsky That sounds great! Are you also on our Discord by any chance? Feel free to ask questions in there as well. Honestly, if you can get it to generate based on the spec and it's working then I'd love to get it into its own repository and we can improve it from there. |
@jzanecook Yes, I am on AIEF Discord. Sounds good, I'll work on it and will let you know when it's ready! |
It looks like the python client was generated using @openapitools/openapi-generator-cli
I'm not crazy about needing Java. Would it be ok to instead require devs to have docker (just for client generation)? There's also openapi-type-codegen ("we do not want to use JAVA codegen in our builds"😅), but then we're using different tooling for the python and js clients... |
I'm also wondering if there should be a single script (in the root |
|
Is your feature request related to a problem? Please describe.
We want to generate as much of the code as possible from the OpenAPI. This will help us to stay up to date with the protocol and in the same time it improves development speed and limits possible bugs in implementation.
Describe the solution you'd like
generate
, which will regenerate the codeAdditional context
I would recommend using of the OpenAPI codegens.
Feel free to come with something else
The text was updated successfully, but these errors were encountered: