Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix : Models : updated additional_input #89

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

vignesh14052002
Copy link
Contributor

@vignesh14052002 vignesh14052002 commented Dec 21, 2023

Pull Request

This pull request contains a fix for v1 API endpoints for create task and execute step not accepting additional_input parameter , For more details refer this issue #82

Description

Issue :

v1 API endpoints for create task [POST] /ap/v1/agent/tasks and execute step [POST] /ap/v1/agent/tasks/{taskid}/steps not accepting additional_input parameter

Reason :

The pydantic models Task and Step has not configured additional_input property

Changes :

Made additional_input property to type Optional[Dict[str, Any]] in python sdk

Checklist

Please review and check the following items to ensure your pull request can be processed smoothly:

  • My code adheres to the project's coding standards and style guidelines.

  • I have tested my changes thoroughly, including unit tests where applicable.

  • I have updated the documentation to reflect any changes made in this pull request.

  • My branch is up-to-date with the latest changes from the main branch.

  • I have received code review feedback and addressed any comments or concerns.

References, Fixes and Closes

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
agentprotocolai ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 7:04am

@hackgoofer
Copy link
Contributor

@vignesh14052002 Can you join the meeting with us at 9:30am PST at the foundation discord? https://discord.com/invite/bJnNh666C3

Let's get this merged and resolved.

@hackgoofer
Copy link
Contributor

@jzanecook to make sure that the test suite covers the case.

@jzanecook
Copy link
Collaborator

@jzanecook to make sure that the test suite covers the case.

Checked the test suite, this is currently failing.

Here's the output:
image

@vignesh14052002
Copy link
Contributor Author

@jzanecook how to run the test suite? i ran packages\sdk\python\examples\minimal.py to start the server and ran both testing_suite/local_test.sh and testing_suite/test.sh

image

@vignesh14052002
Copy link
Contributor Author

vignesh14052002 commented Jan 23, 2024

@jzanecook maybe the failed test cases are from js-sdk , i see the test cases are already failing in main , so reverted my js-sdk changes , you can review the python part alone

@vignesh14052002
Copy link
Contributor Author

@vignesh14052002 Can you join the meeting with us at 9:30am PST at the foundation discord?

sure

@hackgoofer
Copy link
Contributor

https://agentprotocol.ai/compliance here is how you test.

@vignesh14052002
Copy link
Contributor Author

https://agentprotocol.ai/compliance here is how you test.

@hackgoofer checked it , test cases passed

@vignesh14052002
Copy link
Contributor Author

@hackgoofer @jzanecook Remainder! , seems you forgot to merge this PR

@jzanecook jzanecook merged commit da31fb5 into AI-Engineer-Foundation:main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants