-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix/#168] 캘린더 이전 날짜 선택 막기, 경고문구 디자인 수정. #181
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳굳 ,,, 꽤나 복잡한 처리인데 완벽하네요 멋집니다!
if (newDate.length > 7) { | ||
setTimeout(() => { | ||
setMeetingInfo((prev: MeetingInfo) => { | ||
return { ...prev, availableDates: [] }; | ||
}); | ||
}, 1000); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 7일 이상 선택하면 1초 뒤에 자동으로 선택이 풀리는거 맞나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 맞습니다. 7일 이상 선택하면, 1초 뒤에 자동으로 선택이 풀리고 그동안 경고문구가 빨간 색으로 변한뒤 잠시 글이 좌우로 흔들리는 애니메이션이 나옵니다.
/* .bg-dark .rmdp-button:not(.rmdp-action-button):hover { | ||
background-color: var(--rmdp-main1); | ||
} */ | ||
|
||
.rmdp-day.rmdp-disabled { | ||
color: var(--rmdp-grey6) !important; | ||
} | ||
|
||
.rmdp-day.rmdp-disabled.rmdp-deactive { | ||
color: var(--rmdp-grey10) !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 setDates.css를 따로 뺀 건 라이브러리 자체 css를 삭제하는 코드를 따로 분리하기 위해서인가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 네네 맞습니다. 라이브러리 자체 css 코드를 수정하는 것들이 많아서 너무 길어지길래 그러한 목적을 가진 css 코드만 따로 뺏습니다.
transform: translateX(0); | ||
} | ||
} | ||
${({ $dateLength }) => $dateLength > 7 && `animation: vibration 0.1s 5;`}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
animation : ${({ $dateLength }) => $dateLength > 7 ? vibration 0.1s 5; : none};
이전까지 별고민 없이 이런식으로 사용했던 것 같은데 동헌이가 쓴 것 같이 사용하는게 훨씬 알맞네요!!! 뭔가 백틱으로 애니메이션 속성 전체를 넣을 생각을 못했음!!
우와 이거 빨리 반영됐으면 좋겠다! FGI할때 이전 날짜 왜 선택되냐고 많이 혼남 |
LGTM |
✨ #168 ✨
todo
📌 내가 알게 된 부분
${({ $dateLength }) => $dateLength > 7 && `animation: vibration 0.1s 5;`};
📌 공유하고 싶은 부분
📌 질문할 부분
📌스크린샷
2023-09-20.3.35.48.mov