Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#188] 확정된 회의 링크 입장시 리다이렉션 #196

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

simeunseo
Copy link
Member

@simeunseo simeunseo commented Oct 9, 2023

#188

todo

  • 확정된 회의 링크 입장시 리다이렉션

📌 내가 알게 된 부분

  • state 변경 시기를 항상 주의할 것

📌 공유하고 싶은 부분

  • 회의명 보여주는 부분을 처리하면서 원래 없던 setState를 추가했는데, 현재 이 방이 확정된 회의인지 아닌지를 판단하기 전에 setState를 실행하여 오류가 나게되는 간단한 상황이었습니다. 순서를 조정하여 해결하였습니다.

📌스크린샷

2023-10-10.2.55.59.mov

확정된 회의이므로 바로 리다이렉트되는 모습

@simeunseo simeunseo added fix fix 은서 은서의 개발 라벨 labels Oct 9, 2023
@simeunseo simeunseo requested review from ljh0608 and eastlaw80 October 9, 2023 17:56
@simeunseo simeunseo self-assigned this Oct 9, 2023
@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
asap ✅ Ready (Inspect) Visit Preview Oct 9, 2023 5:56pm

@github-actions github-actions bot added the size/S label Oct 9, 2023
Copy link
Contributor

@eastlaw80 eastlaw80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~LGTM^___^

Copy link
Member

@ljh0608 ljh0608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simeunseo simeunseo merged commit 5e68651 into develop Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fix size/S 은서 은서의 개발 라벨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants