Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change read/write method to accept Reader/Writer interface instead implementation #3

Open
nfalco79 opened this issue Feb 27, 2020 · 1 comment

Comments

@nfalco79
Copy link

Could you change the methods read/write to accept the interfaces Reader/Writer instead the bufferred implementation.
This is better for who handle ConfigParser with string instead directly from files and avoid flush every times also if we are using not buffered writer.

@ASzc
Copy link
Owner

ASzc commented Mar 3, 2020

Plain Readers don't offer the readLine method, which is core to the parser. I can add another overloaded method: public Ini read(Reader reader) that simply wraps the given Reader in a BufferedReader. However, it's not clear from your description if that'd work for your use case.

I can wrap a Writer in a BufferedWriter as well, but I'm also unclear if that'd work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants