Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Replace preview button always saves gird image #16115

Closed
4 of 6 tasks
FA7770 opened this issue Jun 30, 2024 · 2 comments
Closed
4 of 6 tasks

[Bug]: Replace preview button always saves gird image #16115

FA7770 opened this issue Jun 30, 2024 · 2 comments
Labels
bug Report of a confirmed bug

Comments

@FA7770
Copy link

FA7770 commented Jun 30, 2024

Checklist

  • The issue exists after disabling all extensions
  • The issue exists on a clean installation of webui
  • The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • The issue exists in the current version of the webui
  • The issue has not been reported before recently
  • The issue has been reported before but has not been fixed yet

What happened?

When changing previews of checkpoints, LoRA, etc. from the "Replace preview" button in the "Edit metadata" menu, the grid image is always saved as a preview, even if a single image is selected from the gallery.

Steps to reproduce the problem

1.Generate on the condition that a grid is generated in the gallery, with a batch count or batch size of two or more.
2.Select a single image in the gallery (other than a grid image).
3.Click the "Replace preview" button in the "Edit metadata" menu.

What should have happened?

The image of the selected gallery is saved as a preview, not a grid image.
I don't remember the exact version, but as of about 1.7.0, it was possible to save the preview in a single image.

What browsers do you use to access the UI ?

Mozilla Firefox, Google Chrome

Sysinfo

sysinfo-2024-06-30-06-08.json

Console logs

venv "H:\xl4\stable-diffusion-webui\venv\Scripts\Python.exe"
Python 3.10.6 (tags/v3.10.6:9c7b4bd, Aug  1 2022, 21:53:49) [MSC v.1932 64 bit (AMD64)]
Version: v1.9.4-169-ga30b19dd
Commit hash: a30b19dd5536f463222e484aef2daf466b49ee85
Launching Web UI with arguments: --xformers
Loading weights [6ce0161689] from H:\xl4\stable-diffusion-webui\models\Stable-diffusion\v1-5-pruned-emaonly.safetensors
Creating model from config: H:\xl4\stable-diffusion-webui\configs\v1-inference.yaml
Running on local URL:  http://127.0.0.1:7860

To create a public link, set `share=True` in `launch()`.
H:\xl4\stable-diffusion-webui\venv\lib\site-packages\huggingface_hub\file_download.py:1132: FutureWarning: `resume_download` is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use `force_download=True`.
  warnings.warn(
Startup time: 12.5s (prepare environment: 2.4s, import torch: 3.8s, import gradio: 0.8s, setup paths: 1.0s, initialize shared: 2.0s, other imports: 0.6s, load scripts: 0.9s, create ui: 0.4s, gradio launch: 0.5s).
Applying attention optimization: xformers... done.
Model loaded in 4.7s (load weights from disk: 0.5s, create model: 0.5s, apply weights to model: 2.3s, calculate empty prompt: 1.2s).
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 20/20 [00:04<00:00,  4.23it/s]
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 20/20 [00:04<00:00,  4.45it/s]
Total progress: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 40/40 [00:11<00:00,  3.36it/s]
Total progress: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 40/40 [00:11<00:00,  4.44it/s]

Additional information

No response

@FA7770 FA7770 added the bug-report Report of a bug, yet to be confirmed label Jun 30, 2024
@w-e-w w-e-w added the bug Report of a confirmed bug label Jun 30, 2024
@w-e-w w-e-w mentioned this issue Jun 30, 2024
4 tasks
@w-e-w
Copy link
Collaborator

w-e-w commented Jun 30, 2024

thanks for the bug report
can't believe we haven't noticed it ourselves after almost a year
fix PR

@w-e-w w-e-w removed the bug-report Report of a bug, yet to be confirmed label Jun 30, 2024
@FA7770
Copy link
Author

FA7770 commented Jul 1, 2024

Thanks for the quick checking and fixes!

@w-e-w w-e-w closed this as completed Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of a confirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants