Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-generate Bison parser files in Repo #1878

Open
dgovil opened this issue Oct 1, 2024 · 0 comments
Open

Pre-generate Bison parser files in Repo #1878

dgovil opened this issue Oct 1, 2024 · 0 comments
Labels
good first issue Good one-day project for beginners without much knowledge of the code base help wanted A task that is desired, but needs somebody to commit the effort to implement it. oslc Related to the osl->oso compiler

Comments

@dgovil
Copy link

dgovil commented Oct 1, 2024 •
edited
Loading

Problem

OSL builds currently generate the Bison parser code during their builds.
It would be really great if someone could pre-generate these files and include them in the repo for the build system to use.

This would allow reducing the dependency count in OSL on Windows/Mac to not require bison on each machine, and would make builds ever so slightly more efficient for each builder.

This would require adjusting:

  • src/liboslexec/CMakeLists.txt, src/liboslquery/CMakeLists.txt and src/liboslcomp/CMakeLists.txt to allow using the pre-generated files.
  • INSTALL.md and the various platform doc/build_install/windows/Readme.md files that mention requiring bison, to making it optional.
  • doc/build_install/windows/build_osl.py to make bison an optional build component.
@lgritz lgritz added good first issue Good one-day project for beginners without much knowledge of the code base help wanted A task that is desired, but needs somebody to commit the effort to implement it. oslc Related to the osl->oso compiler labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good one-day project for beginners without much knowledge of the code base help wanted A task that is desired, but needs somebody to commit the effort to implement it. oslc Related to the osl->oso compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lgritz @dgovil