Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make positive input prompt drag resizable. #1236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FeepingCreature
Copy link
Contributor

@FeepingCreature FeepingCreature commented Sep 30, 2024

As per mention in Discord.

Problem: Drag bar currently occupies five invisible pixels at the bottom of the text widget. Not sure how to fix that in the layout.

@FeepingCreature FeepingCreature force-pushed the fix/drag-resize branch 4 times, most recently from b0ea6b8 to 4cebcb5 Compare September 30, 2024 21:08
@Acly
Copy link
Owner

Acly commented Oct 21, 2024

It works pretty well.

Would be nice to have a visual indicator, and to avoid the extra layout space. You can put the widget on top of the text box by not adding it to the layout and using move to set a fixed position instead.

This is how the translation button is positioned, same code should work (could also consider moving it to the same place): https://github.com/Acly/krita-ai-diffusion/blob/main/ai_diffusion/ui/region.py#L393

As for visual indicator, something like this?
image

Diagonal lines in the bottom right are also typical, but the translation button is already there and moving it looks a bit weird:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants