Skip to content

Latest commit

 

History

History
32 lines (31 loc) · 1.23 KB

feedback.md

File metadata and controls

32 lines (31 loc) · 1.23 KB

Ride Share

What We're Looking For

Feature Feedback
Baseline
Used Git Regularly
Answer comprehension questions
Wave 1
Appropriate use of Ruby's Date
Trip has a helper method to calculate duration
User (passenger) has a method to calculate total cost of all trips
Tests for wave 1
Wave 2
Driver inherits from User
Driver has add_driven_trip method
Driver has method to calculate average rating
Driver has method to calculate net expenditures and it uses super
Driver has a method to calculate total revenue
Tests for wave 2
Wave 3
TripDispatcher has a new method to create trips
creating a trip in TripDispatcher relies on methods in Driver and User (passenger) to modify their own attributes
Complex logic was correctly implemented
Tests for request_trip
Methods from wave 1 and 2 handle incomplete trips
Tests for wave 1 and 2 methods with incomplete trips
Wave 4 (Optional)
TripDispatcher now assigns trips to either the newest driver (no trips), or the driver who has not driven in the longest time
Appropriate helper methods were made to help with complex logic
Tests for wave 4
Overall