Skip to content

Latest commit

 

History

History
62 lines (42 loc) · 2.31 KB

feedback.md

File metadata and controls

62 lines (42 loc) · 2.31 KB

Task List

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages ✔️?
Routes follow RESTful conventions ✔️?
Uses named routes (like _path) ✔️?
Creates Models and migrations ✔️?
Creates styled views ✔️?
Handles errors like nonexistant tasks ✔️?
Uses form_with to render forms in Rails ✔️?

Functional Requirements/Manual Testing

Functional Requirement yes/no
Successfully handles index & show ✔️?
index & show tests pass ✔️?
Successfully handles: New, Create ✔️?
New, Create tests pass ✔️?
Successfully handles: Edit, Update ✔️?
Successfully handles: Destroy, Task Complete ✔️?

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 5+ in Functional Requirements
Yellow (Approaches Standards) 3+ in Code Review && 4+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-2 in Code Review or 0-3 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized