-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Ember Table 6 #995
Comments
Hey that's great news! Maybe we could consider
|
The most recent project I built with ember-table had a highly stylized table and we had a lot of issues getting table borders to work with You can see these visual glitches even on ember-table's own documentation. The header specifies a border style, and it allows content to "peek thru" where the border would be as you scroll. To save you a bunch of SO dumpster diving, this isn't ember-table's fault. It's due to bugs in Chrome's table renderer that are in some cases a decade old, and blocked by undefined behavior in the HTML table spec. Help isn't coming. One possible solution is to avoid This is a heavy handed workaround, and if it's bothersome enough, perhaps ember-table could implement sticky rows & cols by moving the "many tables, synchronized" into the lib as an implementation detail; saving all the ember-table consumers. And ditch |
Thought of another problem with the use of Expectation: you grab the line to resize Actual: the handle is on the right edge of the previous cell You can't set say |
@apellerano-pw I appreciate the analysis and feedback, but I'm not sure any of that work is actionable in the scope of an upcoming major version release. I suspect that analysis might be better in an independent issue. @gwak I think those changes sound reasonable, but I'm not going to block a major release on them. The sound like reasonable enhancements. I expect the composability of the system is easier to iterate on after we adopt Glimmer components, maybe in the guise of breaking changes for a major version following this one. I'm amenable. |
I've cut the first pre-release. v6.0.0-0 is out there, contains the migration to a more accurate scale calculation method. |
+1 for customisable checkbox and collapse icon/button |
Its that time again! Building on html-next/vertical-collection#400, I propose a new major version of Ember Table.
master
and use the6.0
label. See https://github.com/Addepar/ember-table/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A6.0+What else?
The text was updated successfully, but these errors were encountered: