Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA role should be appropriate for the element #492

Open
fmazeiras opened this issue Jun 23, 2023 · 7 comments
Open

ARIA role should be appropriate for the element #492

fmazeiras opened this issue Jun 23, 2023 · 7 comments

Comments

@fmazeiras
Copy link

since version 8.1.4 the component have accessibility violation when using axe to check

the error is

@christoshrousis
Copy link

@martinholecekmax
Copy link

Same problem here. Any idea how to fix it?

@AdrianFahrbach
Copy link

Same here! Would be nice to get this fixed, since this should be a one-liner.

@MonikaPatelIT
Copy link

Same here. Let us pass role as prop if it's okay

@fandporsh
Copy link

fandporsh commented Nov 14, 2023

Hello same problem don't pass Jest-Axe

in file PaginationBoxView.js

      <ul
        className={className || containerClassName}
        role="navigation"
        aria-label="Pagination"
      >

no need role for < ul >

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul#specifications

@ViktorSoroka07
Copy link

+1

@fmazeiras
Copy link
Author

Hello,

i receive this comment "This is actually a bug in v8.1.3. v8.1.2 is the last version that does not have this accessibility violation." by email but it does not appear here.

I can confirm that this issue is still in the last version 8.1.5 because the pull request that can fix it is not merged fix #459: Remove incorrect aria role navigation #494

regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants